I've rearranged Makefile for setgid test case. I've put _16 related macros to compat_16.mk file. The original Makefile includes it. So when I work on more _16 test cases, I just have to do the same. I'll do the same on _64. I choose utils as its directory name. Please put attached files compat_16.mk and newer_64.mk to ltp/testcases/kernel/syscalls/utils. Signed-off-by: Masatake YAMATO <yamato@redhat.com>.
I've done on the other test cases. In addition, I've cleaned up Makefiles related to _64 and _16 testcases as suggested by Garrett Cooper <yanegomi@gmail.com>. Signed-off-by: Masatake YAMATO <yamato@redhat.com>. Garret suggested: You can avoid situations like the above by doing something like this in your Makefiles: SRC := $(patsubst %.c,%,$(wildcard *.c)) MAKE_TARGETS := $(SRCS) $(addsuffix _16,$(SRCS)) all: $(MAKE_TARGETS) %_16: %.c %_16: CFLAGS += -DUSE_COMPAT16_SYSCALL=1 -DTST_USE_COMPAT16_SYSCALL=1
Addition of ftruncate64 syscall test support. Signed-off-by: Masatake YAMATO <yamato@redhat.com>.
Put-libtestsuite-to-a-more-common-place.patch Roy Lee <roylee17@gmail.com> noted: Referring to the sync_pipes API, create_sync_pipes(), wait_son_startup(), notify_startup(), which is defined in the: testcases/kernel/syscalls/lib/libtestsuite.[ch], I found the new sync_pipes API very convenient to synchronize processes. However the naming might pose some semantic restrictions on their usages. Since it can be used for making parent to wait child, and vice versa, perhaps a better naming should be used. For example: sync_pipes_create (), sync_pipes_wait (), sync_pipes_notify(), other names will be good as long as they don't assume the caller is child or parent. Furthermore, since it is also suitable for being used in common test cases, moving it outside the syscalls's directory to a more common place might be a good idea. Renaud Lottiaux <Renaud.Lottiaux@kerlabs.com> noted: I fully agree with your remarks. But if you want to make these functions more generic, it should be possible to call sync_pipe_wait / notify several times, which is not possible in the current code since I close file descriptors in these functions. A quite simple solution is to keep these file descriptors opened, and to add a function to close them or simply let these file descriptors being closed by libC or kernel at process end. Signed-off-by: Roy Lee <roylee17@gmail.com>.
This patch fixes a concurrency issue in ftruncate04. In the expected scenario, child should hold the lock of the file before parent access it. On a loaded system, however, the parent might access the file before the child, hence resulting in a unexpected 'open fail'. By, Roy Lee <roylee17@gmail.com>.
standardize makefiles (punt UCLINUX/COLDFIRE cruft, build everything with -Wall and user-optimizations, remove pointless targets in favor of implicit ones, etc...)
Applied fixes by Paul J.Y. Lahaie to implement support for UCLinux
warnings cleanup
Applied Vasan Sundar's Makefile patches.
*** empty log message ***
Separate make and make install
restructuring work done, and adding about 400 testcases
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, select a symbolic revision name using the selection box, or choose 'Use Text Field' and enter a numeric revision.